feat: add new column for FAP review of time requested - #1584
Merged
Conversation
zacharyjhankin
changed the title
Contributor
|
Looks good to me 👍 |
zacharyjhankin
marked this pull request as ready for review
June 19, 2026 08:49
zacharyjhankin
requested review from
simonfernandes
and removed request for
a team
June 19, 2026 08:49
simonfernandes
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the details of how much allocation time that a proposal requested so the FAP reviewers know how much time that they should allocate.
Motivation and Context
When you're doing a FAP review it is not clear how many hours that the proposal wants for an instrument so this PR makes it very obvious to them
How Has This Been Tested
Manual testing with proposals in multiple states
Changes
Key is adding a new graphql endpoint for requesting the time requested of a proposal
Tests included/Docs Updated?
I have added tests to cover my changes.
All relevant doc has been updated.
No need for docs as its very intuative what the new info means.